Allow ability to set_pathfinding_scores_source#148
Allow ability to set_pathfinding_scores_source#148benthecarman merged 1 commit intolightningdevkit:mainfrom
set_pathfinding_scores_source#148Conversation
|
I've assigned @benthecarman as a reviewer! |
Anyitechs
force-pushed
the
import-scorer
branch
from
8ba3239 to
28e3760
Compare
ldk-server/src/util/config.rs
Outdated
| announcement_addresses = ["54.3.7.81:3001"] | ||
| rest_service_address = "127.0.0.1:3002" | ||
| alias = "LDK Server" | ||
| pathfinding_scores_source_url = "https://rapidsync.lightningdevkit.org/" |
There was a problem hiding this comment.
The path finding scores is different than RGS. Can you just use an example url here and below?
ldk-server/ldk-server-config.toml
Outdated
| announcement_addresses = ["54.3.7.81:3001"] # Lightning node announcement addresses | ||
| rest_service_address = "127.0.0.1:3002" # LDK Server REST address | ||
| alias = "ldk_server" # Lightning node alias | ||
| pathfinding_scores_source_url = "" # External Pathfinding Scores Source |
There was a problem hiding this comment.
We should have this commented out, not as an empty string
There was a problem hiding this comment.
My understanding is that this is supposed to show users we support importing external scorer files, commenting out the field won't make that obvious at first, no?
There was a problem hiding this comment.
I imagine most people will start by copying this example file. I don't think we want people defaulting to having an external scorer. It will also fail as an empty string because that is not a valid url
There was a problem hiding this comment.
It will also fail as an empty string because that is not a valid url
No, this is already handled in the build() function. An empty string returns None and we only set the external scorer in main when we have Some(valid_url).
There was a problem hiding this comment.
Oh I see we are filtering for non empty strings. We aren't doing that for any other param so we should just remove that to be consistent
Anyitechs
force-pushed
the
import-scorer
branch
from
28e3760 to
13c580b
Compare
Anyitechs
force-pushed
the
import-scorer
branch
from
13c580b to
7acedf2
Compare
3 participants
This introduces the ability for users to configure an external pathfinding scores source for the node.
Closes #114