Merged
Conversation
Contributor
Author
|
This does introduce 5 new instances of direct leaks in the address sanitizer logs, but I don't know how to fix this differently. Ideas welcome @tnull :) |
tnull
previously approved these changes
Sep 13, 2023
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Thank you!
Confirmed that test case reproduces the reported failure and is fixed by the given patch.
Unfortunately I don't have a good idea either, but leaking is always preferable over segfaulting...
arik-so
force-pushed
the
arik/2023/09/find-route-segfault-fix
branch
from
eed8878 to
e03076f
Compare
tnull
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.