Expose lsps0_message_handler.handle_request#15
Conversation
yanganto
changed the title
lsps0_message_handler.handle_request
yanganto
force-pushed
the
expose-handler-request
branch
from
58ba8f2 to
111ab58
Compare
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
I don't think we should expose arbitrary internals through the public API. So if you'll need access for testing I'd suggest to either change it locally or hide the exposure behind the cfg(test) flag.
| @@ -1,3 +1,4 @@ | |||
| #![allow(missing_docs)] | |||
There was a problem hiding this comment.
We set #![deny(missing_docs)] crate-wide for good reason and def. should allow them here.
There was a problem hiding this comment.
Is there demo client to request on the public interface of lsp handler? It will be nice for people to check after integrate the handler. Many thanks.
There was a problem hiding this comment.
I think @johncantrell97 has a branch of ldk-sample with the LSP client and LSPS2 integrated.
@johncantrell97, mind sharing a link here?
There was a problem hiding this comment.
I forget the state it's in but I think it was working: https://github.com/johncantrell97/ldk-sample/pull/1/files
3 participants
Would
lsps0_message_handler.handle_requestbe public and return the response?Such that people integrate the handler will easier to verify the handler work after integration.
Thanks in advance. 🙏