This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Restructure crate#48
Merged
Merged
Conversation
As the implementation isn't ready as of yet, we hide LSPS1 for now but make sure we test it in CI so that future changes don't break code compatibility.
tnull
force-pushed
the
2023-11-crate-restructuring
branch
from
7258a64 to
017d89a
Compare
tnull
force-pushed
the
2023-11-crate-restructuring
branch
from
017d89a to
547599b
Compare
tnull
force-pushed
the
2023-11-crate-restructuring
branch
from
547599b to
ad3cc2f
Compare
johncantrell97
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34
The structure of this crate was up for discussion right from the beginning (see #1) and we tentatively chose a semantic structure with modules named after their purpose (
transport,channel_request,jit_channel).However, given that the specifications now follow a "no versioning" model in which breaking changes will result in a new LSPSX standard this structure doesn't really make sense anymore. In particular when LSPS4 will become a reality it live side-by-side with LSPS2, so we will have two
jit_channelstandards for a while.To this end, we rename the modules accordingly and
cfg-gate LSPS1 for now as it's not usable yet, although now checked in CI to make sure we won't break compatibility with it.