This repository was archived by the owner on Jan 6, 2025. It is now read-only.
expose message type id#52
Closed
johncantrell97 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
hm I guess maybe user might not need it. could just give all custom messages to the handler and it will return Ok(None) if it doesn't know about the message type? |
Collaborator
Yeah, this was kind of intentional. We'll revisit where we should expose which types when tackling #36. We may want to expose said id then under |
Collaborator
|
Now superseded by #58. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this became hidden in the refactor. it is needed when a user is writing their custom message handler.