This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Add initial proptest to check forwarding amount calculation#56
Merged
Conversation
tnull
force-pushed
the
2023-11-add-proptest
branch
3 times, most recently
from
cdc0d3d to
175696c
Compare
tnull
force-pushed
the
2023-11-add-proptest
branch
from
e497873 to
612f0e5
Compare
Collaborator
Author
|
Rebased now that #53 landed and either addressed feedback or tracking it elsewhere. |
tnull
force-pushed
the
2023-11-add-proptest
branch
from
612f0e5 to
77d9078
Compare
Collaborator
Author
|
Rebased after #58 landed. @johncantrell97 Let me know if I can merge. |
Collaborator
Author
|
Merging as ACKed elsewhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #53, fixes #45.We introduce an initial property-based test to check
calculate_amount_to_forward_per_htlc. We also adapt the latter to be less susceptible to over/underflows.