This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Scaffolding for event handling in future protocols#7
Merged
Conversation
208d1e2 to
6a2c4aa
Compare
tnull
reviewed
Jun 21, 2023
tnull
reviewed
Jun 21, 2023
Collaborator
tnull
left a comment
There was a problem hiding this comment.
I also wonder if we need to persist this event queue? What happens when the node is shutdown and the users hasn't handled all events. Is the state of all protocols really so stateless that everything will start over? If not and we don't persist it, we need to make sure in each LSPS that every necessary event is re-generated on startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the concept of events to the library. Future protocols should:
pending_eventsEventQueue.End user is currently expected to poll for events using either:
get_and_clear_pending_eventsin order to retrieve all currently queued events without blocking (returns empty vec if nothing present)or
get_next_eventblocks until next event is ready and returns itPerhaps we want an async version that returns a Future as well?