Restrict tokio to 1.14 as a dev-dependency#1315
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Feb 17, 2022
Merged
Restrict tokio to 1.14 as a dev-dependency#1315TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
Conversation
This maintains our MSRV for simple `cargo test` runs, but doesn't restrict users to any specific 1.X tokio version.
Collaborator
Author
|
Note that this fixes the |
arik-so
approved these changes
Feb 17, 2022
3 tasks
Contributor
|
fyi alternative view bitcoindevkit/bdk#547 |
Collaborator
Author
|
I think bumping MSRV beyond 1.41 is unacceptable, but I commented on the BDK issue. |
4 tasks
jkczyz
approved these changes
Feb 17, 2022
notmandatory
added a commit
to bitcoindevkit/bdk
that referenced
this pull request
Feb 18, 2022
b04bb59 Pin tokio version to ~1.14 (Steve Myers) Pull request description: ### Description The `tokio` project recently changed their MSRV to `1.49.0`. This PR will pin the `tokio` dependency version to `~1.14` which is prior to their MSRV increase. ### Notes to the reviewers The LDK team took this approach for their `tokio` dev-dependency, see lightningdevkit/rust-lightning#1315. As long as `tokio` backports bug fixes to`1.14.x` releases this should be safe. If we need any new features we can revisit this decision. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [ ] I've updated `CHANGELOG.md` ACKs for top commit: LLFourn: ACK b04bb59 Tree-SHA512: a44d61e0d644900837b5a99e0f2b9e5706cf9932f7430c3a2c8adbff37c82e4a6a545849fe031da748fcd8c8a70f5266d6974c5b6634b50af5eae148b9a26635
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This maintains our MSRV for simple
cargo testruns, but doesn'trestrict users to any specific 1.X tokio version.