[0.0.111-bindings] Add a bindings-only version of Future::register_callback#1736
Conversation
While we could, in theory, add support to the bindings logic to map `Box<dyn Trait>`, there isn't a whole lot of use doing so when its incredibly trivial to do directly. This adds a trivial wrapper around `Future::register_callback` that is only built in bindings and which is linked in the `register_callback` docs for visibility.
as the first is quite a mouthful, and the second isn't materially less specific.
|
Oops, right, this should go upstream first. Please bikeshed the function name at #1737 instead and we should land that first. |
Codecov ReportBase: 90.75% // Head: 90.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 0.0.111-bindings #1736 +/- ##
====================================================
+ Coverage 90.75% 90.78% +0.03%
====================================================
Files 86 86
Lines 46530 46530
Branches 46530 46530
====================================================
+ Hits 42227 42242 +15
+ Misses 4303 4288 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Is the rename from #1734, not a breaking change? Or are we okay with that? |
|
Yea, it's not breaking, but we also backported the adoption of the struct itself, and it seems more annoyance than it's worth to ship a struct and then rename it in the next release. |
While we could, in theory, add support to the bindings logic to map
Box<dyn Trait>, there isn't a whole lot of use doing so when itsincredibly trivial to do directly.
This adds a trivial wrapper around
Future::register_callbackthatis only built in bindings and which is linked in the
register_callbackdocs for visibility.This also has a backport of #1734 because why not.