Re-export bech32#3208
Closed
benthecarman wants to merge 1 commit intolightningdevkit:mainfrom
Closed
Conversation
In the upgrade to rust-bitcoin 0.31, bech32 is no longer re-exported. This is needed for the u5 type by the NodeSigner for the sign_invoice function. This just re-exports the bech32 crate to handle this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3208 +/- ##
==========================================
- Coverage 89.80% 89.70% -0.11%
==========================================
Files 122 122
Lines 101621 101791 +170
Branches 101621 101791 +170
==========================================
+ Hits 91261 91311 +50
- Misses 7674 7782 +108
- Partials 2686 2698 +12 ☔ View full report in Codecov by Sentry. |
Contributor
Collaborator
|
Yea, we'll see what happens in that PR first, then we can revisit this I think. I kinda hate the re-exporting thing, but maybe others have different opinions. |
Collaborator
|
Closing as abandoned. We shouldn't need this post-0.32. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the upgrade to rust-bitcoin 0.31, bech32 is no longer re-exported. This is needed for the u5 type by the NodeSigner for the sign_invoice function. This just re-exports the bech32 crate to handle this.