Add invoice serialization tests [TestOnly][Minor]#3266
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Aug 23, 2024
Merged
Add invoice serialization tests [TestOnly][Minor]#3266TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3266 +/- ##
==========================================
+ Coverage 89.82% 89.87% +0.05%
==========================================
Files 125 126 +1
Lines 102830 103436 +606
Branches 102830 103436 +606
==========================================
+ Hits 92368 92965 +597
- Misses 7752 7760 +8
- Partials 2710 2711 +1 ☔ View full report in Codecov by Sentry. |
optout21
changed the title
TheBlueMatt
reviewed
Aug 22, 2024
Collaborator
|
Otherwise LGTM, thanks. |
optout21
changed the title
TheBlueMatt
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only adds some tests for invoice serialization/deserialization, to create a test harness in preparation of Bech32 encoding changes (#3244 ).
This PR can be merged optionally, or skipped, and the tests added with #3244 . It is more clear that behavior does not change if tests are added upfront.