Skip to content

[Early Draft] Splicing prototype #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
optout21 wants to merge 119 commits into from
Closed

[Early Draft] Splicing prototype #3274

optout21 wants to merge 119 commits into from

Conversation

@optout21
Copy link
Contributor

@optout21 optout21 commented Aug 27, 2024 •
edited
Loading

Splicing prototype, draft; PR for visibility (not intended for merging as for now).

Current baseline: v0.0.123, plus a not-latest version of dual-funding PR #2302 .

For start, run the splicing integration tests:

RUSTFLAGS="--cfg=splicing" cargo test -p lightning splic

See tests in functional_tests_splicing.rs.

Some documentation is available in README.md.

optout21 and others added 30 commits October 11, 2023 08:34
@optout21
Splicing happy-path proto 3
de78627
@optout21
Splicing happy-path proto 4
2f6d619
@optout21
Move committing to new splice transaction only upon confirmation
04df7b7
@optout21
Extra check to splice test case (no change before locking)
03978ed
@optout21
Reduce redundancy in pre+post+diff storage, check for overflows
a23d7dd
@dunxen
Add V2 constructors to ChannelId
15176d0
@dunxen
f use-only Hash trait
1b8f177
@dunxen
Test builds with #[cfg(dual_funding)] enabled
fcd399d
@dunxen
Add DualFundingChannelContext struct
476f6cb
@dunxen
Create ChannelContext constructor for inbound channels
2e66dc5
@dunxen
Add InboundV2Channel struct
2ee04b0
@dunxen
Create ChannelContext constructor for outbound channels
2f1fcb7
@dunxen
Add OutboundV2Channel struct
5c68d10
@dunxen
Add V2 ChannelPhase variants
23febee
@dunxen @wpaulino @jurvis
Initial InteractiveTxConstructor design
3739aff 
Co-authored-by: Wilmer Paulino <9447167+wpaulino@users.noreply.github.com>
Co-authored-by: Duncan Dean <git@dunxen.dev>
Co-authored-by: Jurvis Tan <5944973+jurvis@users.noreply.github.com>
@jurvis @dunxen
Add more docs and tests
906e01e
@jurvis @dunxen
Add comment on spec clarification
6591432
@dunxen
Add interactive tx constructor to ChannelContext
d3659fa
@dunxen
Add FundingInputsContributionReady event
4b9f03a
@dunxen
Implement support for accepting V2 channels
29e396c
@dunxen
Handle initial commitment_signed for V2 channels
7689e00
@dunxen
Handle interactive signing sessions
d7b69d9
@dunxen
Add option_dual_fund feature
0ac3d9a
@optout21
Splice test: add checks to acceptor node as well
a146bbe
@optout21
Minor cleanup
5db4b3f
@optout21
Update to main, up to Nov 23 70ea110, bitcoin 0.30.2, splice msgs in
dfe53d7
@optout21
Update to main, up to Nov 27, 146a291
d7d2f98
@optout21
Update to main, up to Dec 9 0c67753, channel state refactor
4131866
@optout21
Merge Interactive TX construction branch (dunxen:2023-05-v2channelest…
75eff57 
…ablish) into splice proto
@optout21
Create test with V2 channel open; test_channel_open_v2_and_close
e5122bf
@jkczyz jkczyz self-requested a review August 27, 2024 14:36
@dunxen dunxen mentioned this pull request Aug 30, 2024
Closed
7 tasks
This was referenced Sep 5, 2024
Closed
Closed
Open
Closed
@optout21 optout21 mentioned this pull request Sep 12, 2024
Closed
@optout21
Remove redeem_script from signing utility, it can derive it
d8198d2
@optout21
Minor channel cloning touches
3fa228b
@optout21
Rename (RenegotiatingV2 to RenegotiatingV2
7628d00
@optout21
Add V2Channel, merge RenegotiatingChannel into V2Channel
522340d
@optout21
RenegotiatingV2 contains now Channel and ChannelVariants (instead of …
02ac3f1 
…2 Channels, step towards RBF)
@optout21
Merge RenegotiatingFundingOutbound, -Inbound and RenegotiatingV2 phas…
bb7cbd0 
…es into one, with ChannelVariants
@optout21
Adapt channel cloning, as in 3332
e781ca3
@optout21
Rename state to RefundingV2
2bfd08f
@optout21
Channel context for splicing pending: use post if funded, pre otherwi…
4980a99 
…se. Also a rename
@optout21
Add test for payment while splice pending (failing)
6895e92
@optout21
For DualF, split Funded phase into FundingV2 and Funded
bbc89f6
@optout21
FundingV2 has a ChannelVariants, in prep for RBF
796912f
@optout21
Add test for dual funding RBF
25e7579
@optout21
Implement handling of dual funding RBF
71accec
@optout21
Minor, in preparation for Splicing+RBF
b3cc306
@optout21
Transition states in separate method (transition_confirmed_channels),…
c8c091a 
… in preparation for Splicing+RBF
@optout21
Handle RBF during splice negotiation
ba0f36e
@optout21
Some cleanup in Pre/Post states
c594f7d
@optout21
Add checks for funding pubkey (not changing during splicing)
d9c411f
@optout21
Enable splicing on V1 channel as well
6769fa7
@optout21
Unify V1 and V2 splicing tests
9b41ae4
@optout21
Copy link
Contributor Author

optout21 commented Dec 9, 2025

Closing as this prototype is no longer needed 😎

@optout21 optout21 closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyz jkczyz Awaiting requested review from jkczyz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@optout21 @dunxen @jurvis