Log which hop in a path was the most limiting in capacity#3729
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom May 5, 2025
Merged
Log which hop in a path was the most limiting in capacity#3729TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
Conversation
|
I've assigned @valentinewallace as a reviewer! |
TheBlueMatt
force-pushed
the
2025-04-log-limited-hop
branch
from
1ff1208 to
2d41456
Compare
tnull
reviewed
Apr 11, 2025
|
🔔 1st Reminder Hey @valentinewallace! This PR has been waiting for your review. |
TheBlueMatt
force-pushed
the
2025-04-log-limited-hop
branch
from
2d41456 to
056d5da
Compare
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
LGTM. I assume we'll want to land #3707 first
Contributor
|
Ready for rebase? Top commit LGTM. |
Its generally rather difficult to debug the pathfinding logic from a log, and sadly because we cannot feasibly log each step in a pathfinding search there's relatively few options we have for improving this. However, one specific question we occasionally get is "why did the pathfinder decide to use MPP"? While we similarly cannot practically log every possible path the pathfinder could have taken to explain why a specific path which required MPP was taken, we can at least explain which hop in the path was the most limited, which we do here.
TheBlueMatt
force-pushed
the
2025-04-log-limited-hop
branch
from
056d5da to
5a6378b
Compare
Collaborator
Author
|
Mmm, thanks, rebased! |
dunxen
approved these changes
May 5, 2025
valentinewallace
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its generally rather difficult to debug the pathfinding logic from
a log, and sadly because we cannot feasibly log each step in a
pathfinding search there's relatively few options we have for
improving this.
However, one specific question we occasionally get is "why did the
pathfinder decide to use MPP"? While we similarly cannot
practically log every possible path the pathfinder could have taken
to explain why a specific path which required MPP was taken, we can
at least explain which hop in the path was the most limited, which
we do here.
Based on #3707