Skip to content

Address #3509 followups #3748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 2 commits into from
Apr 24, 2025
Merged

Address #3509 followups #3748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb17da9
Address `Notifier::notify` docs nits
tnull Apr 23, 2025
d0f63f5
Drop unnecessary `payment_queue`-cloning
tnull Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lightning-liquidity/src/lsps2/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ impl OutboundJITChannelState {
Ok(Some(forward_payment))
} else {
*self = OutboundJITChannelState::PendingPayment {
payment_queue: payment_queue.clone(),
payment_queue,
opening_fee_msat: *opening_fee_msat,
channel_id: *channel_id,
};
Expand Down
2 changes: 1 addition & 1 deletion lightning/src/util/wakers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ impl Notifier {
/// Wake waiters, tracking that wake needs to occur even if there are currently no waiters.
///
/// We deem the notification successful either directly after any callbacks were made, or after
/// the user [`poll`]ed a previously-completed future.
/// the user [`poll`]ed a previously-generated [`Future`].
///
/// [`poll`]: core::future::Future::poll
pub fn notify(&self) {
Expand Down
Loading