Drop incremental-mutants CI job (0.1)#3954
Merged
TheBlueMatt merged 2 commits intolightningdevkit:0.1from Jul 28, 2025
Merged
Conversation
Previously, the `incremental-mutants` CI job was failing on ~every PR that made actual logic changes, and nobody seemed to really make any effort to address the failures. The failing CI jobs therefore just resulted in additional which in turn could have us getting used to failing CI, introducing some risk of acutal failures slipping through. Of course, it also took up some (considerable?) time in the CI queue that might be better spent on other jobs if no contributors are actually benefitting from the CI job. Here we therefore drop `incremental-mutants` from our CI for the time being.
|
👋 I see @valentinewallace was un-assigned. |
Contributor
Author
|
Will undraft once we reach a conclusive decision on #3948. |
Contributor
Author
|
Also included a second commit fixing |
TheBlueMatt
reviewed
Jul 24, 2025
Contributor
Author
|
Discussed this at the dev sync, everybody seemed to be in favor or at least not against dropping it. So undrafting. |
tnull
force-pushed
the
2025-07-drop-incremental-mutants-0.1
branch
2 times, most recently
from
5ffe039 to
3b59329
Compare
tnull
force-pushed
the
2025-07-drop-incremental-mutants-0.1
branch
from
3b59329 to
ddd31ef
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.1 #3954 +/- ##
==========================================
+ Coverage 87.40% 87.42% +0.02%
==========================================
Files 149 149
Lines 100751 100751
Branches 100751 100751
==========================================
+ Hits 88064 88085 +21
+ Misses 10441 10425 -16
+ Partials 2246 2241 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnull
requested review from
TheBlueMatt
and removed request for
valentinewallace
TheBlueMatt
approved these changes
Jul 28, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
incremental-mutantsCI job was failing on ~every PR that made actual logic changes, and nobody seemed to really make any effort to address the failures. The failing CI jobs therefore just resulted in additional which in turn could have us getting used to failing CI, introducing some risk of acutal failures slipping through. Of course, it also took up some (considerable?) time in the CI queue that might be better spent on other jobs if no contributors are actually benefitting from the CI job.Here we therefore drop
incremental-mutantsfrom our CI for the time being.