Move check_commits to a dedicated workflow CI (0.1)#3967
Merged
TheBlueMatt merged 1 commit intolightningdevkit:0.1from Jul 28, 2025
Merged
Move check_commits to a dedicated workflow CI (0.1)#3967TheBlueMatt merged 1 commit intolightningdevkit:0.1from
check_commits to a dedicated workflow CI (0.1)#3967TheBlueMatt merged 1 commit intolightningdevkit:0.1from
Conversation
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Previously, we introduced a chance dynamically determining the base branch for the check_commits CI job. Unfortunately it used the base_ref variable, which is only set for pull_requests, not for pushes. Here, we hence move `check_commits` to a dedicated workflow that only is run on PRs.
tnull
force-pushed
the
2025-07-fix-the-fix-0.1
branch
from
139b136 to
ccb20c7
Compare
tnull
changed the title
check_commits CI (0.1)check_commits to a dedicated workflow CI (0.1)
TheBlueMatt
approved these changes
Jul 28, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we introduced a chance dynamically determining the base
branch for the
check_commitsCI job. Unfortunately it used the base_refvariable, which is only set for pull_requests, not for pushes. Here, we
hence move
check_commitsto a dedicated workflow that only is run onPRs.