Add basic end-to-end splice tests#4054
Conversation
|
👋 Thanks for assigning @jkczyz as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4054 +/- ##
==========================================
+ Coverage 87.84% 88.67% +0.82%
==========================================
Files 176 176
Lines 131728 131839 +111
Branches 131728 131839 +111
==========================================
+ Hits 115712 116903 +1191
+ Misses 13384 12279 -1105
- Partials 2632 2657 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Some commits, eg Don't process alternative funding confirmations duplicatively could use some motivation in the commit message.
Also, yea, probably worth splitting this up somehow, its kinda a large PR, maybe move the tests and channel-state changes to another one?
|
🔔 1st Reminder Hey @jkczyz! This PR has been waiting for your review. |
wpaulino
changed the title
wpaulino
force-pushed
the
test-basic-splice
branch
from
58da9c9 to
f204eee
Compare
|
🔔 2nd Reminder Hey @jkczyz! This PR has been waiting for your review. |
wpaulino
force-pushed
the
test-basic-splice
branch
from
f204eee to
26a62ab
Compare
|
🔔 1st Reminder Hey @TheBlueMatt! This PR has been waiting for your review. |
wpaulino
force-pushed
the
test-basic-splice
branch
from
26a62ab to
b1e0f7c
Compare
We plan to reuse it for dual-funding/splicing, and those require standard SegWit inputs only.
This guarantees we get a unique txid when calling `provide_anchor_reserves` successively as we're immediately mining (and therefore advancing the chain) the transaction after creating it.
wpaulino
force-pushed
the
test-basic-splice
branch
from
b1e0f7c to
4648a15
Compare
This adds a new test for both splice-in and splice-out in favor of maintaining the existing test. Helpers have been added to DRY up a lot of the logic necessary for driving the splice state machine forward.
wpaulino
force-pushed
the
test-basic-splice
branch
from
4648a15 to
307fa56
Compare
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
I mean, basically LGTM, but I don't really think this needs a second reviewer now. I'll just defer to @jkczyz who can merge when he's happy.
4 participants
No description provided.