Merged
Conversation
1107ab0 added a Vec of future updates to apply during a loop, fixing a borrow checker issue that didn't exist in the merged version of the patch. This simply reverts that small part of the change.
It appears to be effectively-deprecated in Rust now, and didn't really appear to serve a lot of purpose anyway.
TheBlueMatt
force-pushed
the
2020-04-cleanups
branch
from
e904791 to
76786f5
Compare
Codecov Report
|
Collaborator
Author
|
After we moved the ChannelMonitor creation later during Channel init, we never went back and cleaned up ChannelMonitor to remove a number of now-useless Option<>s, so we do that now.
TheBlueMatt
force-pushed
the
2020-04-cleanups
branch
from
76786f5 to
c89514c
Compare
This was referenced Apr 19, 2020
Closed
valentinewallace
approved these changes
Apr 20, 2020
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
thanks for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few trivial cleanups, most of them to address new rustc warnings.