Raise max to_self_delay.#826
Conversation
TheBlueMatt
left a comment
There was a problem hiding this comment.
Docs in config.rs need updating "lightning/src/util/config.rs:132: /// Default value: MAX_LOCAL_BREAKDOWN_TIMEOUT (1008), which we also enforce as a maximum value
" (though that shouldn't mention the non-public constant, either).
0a0956e to
c0aed9b
Compare
|
Thanks missed that, updated. |
Codecov Report
@@ Coverage Diff @@
## main #826 +/- ##
=======================================
Coverage 90.97% 90.97%
=======================================
Files 48 48
Lines 26538 26540 +2
=======================================
+ Hits 24144 24146 +2
Misses 2394 2394
Continue to review full report at Codecov.
|
arik-so
left a comment
There was a problem hiding this comment.
The missing units in the comments are not due to this PR, but I think this PR should absolutely fix them for future readers. Other than that, LGTM.
LN Spec PR lightningdevkit#826 changes full_information to indicate completion of a sequence of reply_channel_range messages.
|
Calling it 0.0.13 because it appears we need this to reasonably open channels live today, which is probably worth merging before shipping a release that can't practically be used. |
lnd requires this to_self_delay for the max channel size (excluding wumbo).
c0aed9b to
b75437d
Compare
lnd requires this to_self_delay for the max channel size
(excluding wumbo).