Conversation
jharveyb
reviewed
Feb 15, 2024
Contributor
jharveyb
left a comment
jharveyb
left a comment
There was a problem hiding this comment.
LGTM! Some small lint failures.
We'll use this to give hints to the parsing logic to implement some additional up front validation.
In this commit, we add a new meta json type. We update the validation logic to ensure we obtain a valid JSON string, add additional tests, and prep for an itest with a more descriptive error message.
Roasbeef
added a commit
to Roasbeef/bips
that referenced
this pull request
Feb 20, 2024
In this commit, we add a new JSON meta type. This is to be used by developers to specify key-value meta data pairs in a manner more friendly than the lower level TLV serialization. This has been implemented in: lightninglabs/taproot-assets#794
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we designate meta type
1as a JSON string meta. We perform upfront validation at the CLI and RPC level, but retain the meta hash only validation at the protocol level (proof validity only cares about hashing, and not the structure)Fixes #783