sphinx: return error source as integer#37
Conversation
joostjager
force-pushed
the
error-source-idx
branch
from
991dab9 to
cd516f6
Compare
Roasbeef
left a comment
Roasbeef
left a comment
There was a problem hiding this comment.
How is this better than just using the pubkey as is? If they appear multiple times in the path, then they'll be present multiple times in the payment path's circuit.
The sender doesn't know whether the failure happened on the first or the second visit of that node. |
joostjager
force-pushed
the
error-source-idx
branch
from
4e4a958 to
ad3ab31
Compare
|
@Roasbeef fixup pushed that adds return struct. I still don't think it is good, for the reasons pointed out above. But it is a small change and the most important thing is to expose the index one way or the other. |
|
@Roasbeef ptal |
Returning as an integer allows a node to occur in the payment path multiple times.
joostjager
force-pushed
the
error-source-idx
branch
from
ad3ab31 to
7d1f799
Compare
cfromknecht
left a comment
cfromknecht
left a comment
There was a problem hiding this comment.
LGTM, nice change! ✅
| // We should understand the node from which error have been received. | ||
| if !bytes.Equal(pubKey.SerializeCompressed(), | ||
| errorPath[len(errorPath)-1].SerializeCompressed()) { | ||
| if source != len(errorPath) { |
There was a problem hiding this comment.
definitely makes these comparisons simpler 👍
3 participants
Returning as an integer allows a node to occur in the payment path
multiple times.