SendPaymentV2 pays only from v0.11 to v0.11 but not pays from v0.11 to v0.12

[LNBIG-COM]

I use SendPaymentV2 gRPC API call for rebalancing (i fill there payment_addr fields from invoice) but I found a strange thing. I cannot pay invoices from lnd-0.11.* created from LND 0.12 (0.12.0-beta.rc1 commit=v0.12.0-beta.rc1-18-gcc0321d1881ed23c9608cf898af2e2a7b347304a)

Here some examples from my logs with arguments data:

Invoice (lnd-21 & lnd-06 are lnd 0.11.* versions):

2021-01-18T19:13:53.829Z lnbig:paidRebalance invoice (lnd-21->lnd-06): { r_hash: <Buffer 2d 3a ab 8f 18 15 e7 10 0b f4 4e 39 d4 09 00 8f 2d 7a 74 5c cf 8e d2 4a 27 0b db 49 fc 36 6f 63>, payment_request: 'lnbc900220n1psqth0epp595a2hrcczhn3qzl5fcuagzgq3ukh5azue78dyj38p0d5nlpkda3sdru2fjkyctvv9hxxefqveex7mfqd3hxgtfjxys8gmeqd3hxgtfsxcsrjvpsxgezqumpw3ejqargwfhh2emgyqmrydpn8ymnyd3sxgurwwfkxuerxveqvd5xzmnwv4kqcqp7sp5gduntsntlfckghq48ws2sxrgf7mt5wv4y3a9qmx7mly2utrmpcgs9qy9qsqj7ctc2rje2kgzrrvhkmxewsxumte5wclr97z4s5ylsj5899zw8m8saepfl9nfcjtltkxv07mc0pudn707vl9f05nng2yrvnp49ywf8gqs3202w', add_index: '19260' } (команда { invoiceFrom: { key: 'lnd-06', pubKey: '03bc9337c7a28bb784d67742ebedd30a93bacdf7e4ca16436ef3798000242b2251' }, payWho: { key: 'lnd-21', pubKey: '02c91d6aa51aa940608b497b6beebcb1aec05be3c47704b682b3889424679ca490' }, amount: 90022, chanId: '624397260287967233', capacity: 16777215, blockHeight: 666645, decodedPayReq: { route_hints: [], features: { '9': [Object], '15': [Object], '17': [Object] }, destination: '03bc9337c7a28bb784d67742ebedd30a93bacdf7e4ca16436ef3798000242b2251', payment_hash: '2d3aab8f1815e7100bf44e39d409008f2d7a745ccf8ed24a270bdb49fc366f63', num_satoshis: '90022', timestamp: '1610997241', expiry: '3600', description: 'Rebalance from lnd-21 to lnd-06 90022 sats through 624397260287967233 channel', description_hash: '', fallback_addr: '', cltv_expiry: '30', payment_addr: <Buffer 43 79 35 c2 6b fa 71 64 5c 15 3b a0 a8 18 68 4f b6 ba 39 95 24 7a 50 6c de df c8 ae 2c 7b 0e 11>, num_msat: '90022000' } })

Result from SendPaymentV2:

2021-01-18T19:13:55.013Z lnbig:paidRebalance payment update (lnd-21->lnd-06) of channel, status=SUCCEEDED, data: { htlcs: [ { status: 'SUCCEEDED', route: [Object], attempt_time_ns: '1610997237438284135', resolve_time_ns: '1610997238517741562', failure: null, preimage: <Buffer c1 63 04 65 5f 8e 33 f7 af 1b fb 6b 44 0c c3 8c 7f cd 8b 93 fd 45 e2 ed 73 8d 4e cc 17 85 d6 a2> } ], payment_hash: '2d3aab8f1815e7100bf44e39d409008f2d7a745ccf8ed24a270bdb49fc366f63', value: '90022', creation_date: '1610997237', fee: '0', payment_preimage: 'c16304655f8e33f7af1bfb6b440cc38c7fcd8b93fd45e2ed738d4ecc1785d6a2', value_sat: '90022', value_msat: '90022000', payment_request: '', status: 'SUCCEEDED', fee_sat: '0', fee_msat: '0', creation_time_ns: '1610997237348176180', payment_index: '93601', failure_reason: 'FAILURE_REASON_NONE' }

And lnd 0.12.* exampes:

Invoice from lnd-10 (0.12.0-beta.rc1 commit=v0.12.0-beta.rc1-18-gcc0321d1881ed23c9608cf898af2e2a7b347304a):

2021-01-18T19:13:55.365Z lnbig:paidRebalance invoice (lnd-03->lnd-10): { r_hash: <Buffer 44 f0 05 fa 7e 2c 3e 9b 1c 7a 2f 12 db 67 5b 08 e2 f7 43 50 e6 f9 6a bd ab 57 75 99 66 a5 ff 5d>, payment_request: 'lnbc42949670n1psqth05pp5gncqt7n79slfk8r69ufdke6mpr30ws6sumuk40dt2a6eje49lawsdrl2fjkyctvv9hxxefqveex7mfqd3hxgtfsxvs8gmeqd3hxgtf3xqsrgv3exsunvdeqwdshgueqw358ymm4va5zqd3jxvmrwwfjxuunyvecx56r2dps8ysxx6rpdehx2mqcqp7sp5hzztmrxhkk52wjq3ll6vvqvjwwd5j349h756dv028vdxwtf83s3q9qyyssquyqgakm5lzv7syycwcnhhhrdyfm4sp8ds8zpg29dwqy6zy0km5zpnz9hpjd8mrwclpfal2v78zpjckjdvxde70j7wvaj8jzfh3g25pcq2qc9hv', add_index: '299537' } (команда { invoiceFrom: { key: 'lnd-10', pubKey: '02bb24da3d0fb0793f4918c7599f973cc402f0912ec3fb530470f1fc08bdd6ecb5' }, payWho: { key: 'lnd-03', pubKey: '032679fec1213e5b0a23e066c019d7b991b95c6e4d28806b9ebd1362f9e32775cf' }, amount: 4294967, chanId: '623679279238545409', capacity: 16777215, blockHeight: 666645, decodedPayReq: { route_hints: [], features: { '9': [Object], '14': [Object], '17': [Object] }, destination: '02bb24da3d0fb0793f4918c7599f973cc402f0912ec3fb530470f1fc08bdd6ecb5', payment_hash: '44f005fa7e2c3e9b1c7a2f12db675b08e2f74350e6f96abdab57759966a5ff5d', num_satoshis: '4294967', timestamp: '1610997236', expiry: '3600', description: 'Rebalance from lnd-03 to lnd-10 4294967 sats through 623679279238545409 channel', description_hash: '', fallback_addr: '', cltv_expiry: '30', payment_addr: <Buffer b8 84 bd 8c d7 b5 a8 a7 48 11 ff f4 c6 01 92 73 9b 49 46 a5 bf a9 a6 b1 ea 3b 1a 67 2d 27 8c 22>, num_msat: '4294967000' } })

And response from lnd-03 (v0.11.*):

2021-01-18T19:13:55.637Z lnbig:paidRebalance payment update (lnd-03->lnd-10) of channel, status=FAILED, data: { htlcs: [ { status: 'FAILED', route: [Object], attempt_time_ns: '1610997235414548090', resolve_time_ns: '1610997235614145813', failure: [Object], preimage: <Buffer > } ], payment_hash: '44f005fa7e2c3e9b1c7a2f12db675b08e2f74350e6f96abdab57759966a5ff5d', value: '4294967', creation_date: '1610997235', fee: '0', payment_preimage: '0000000000000000000000000000000000000000000000000000000000000000', value_sat: '4294967', value_msat: '4294967000', payment_request: '', status: 'FAILED', fee_sat: '0', fee_msat: '0', creation_time_ns: '1610997235369048375', payment_index: '69225', failure_reason: 'FAILURE_REASON_INCORRECT_PAYMENT_DETAILS' }

For paying i use a following code (nodejs):

                let req = {
                    dest: Buffer.from(command.decodedPayReq.destination, 'hex'),
                    amt: command.decodedPayReq.num_satoshis,
                    payment_hash: Buffer.from(command.decodedPayReq.payment_hash, 'hex'),
                    final_cltv_delta: command.decodedPayReq.cltv_expiry,
                    payment_addr: command.decodedPayReq.payment_addr,
                    fee_limit_sat: 0,
                    outgoing_chan_ids: [command.chanId],
                    timeout_seconds: 9,
                }

                debug("sendPaymentV2 (%s->%s) req: %o", command.payWho.key, command.invoiceFrom.key, req)

                let stream = nodeStorage.nodes[command.payWho.key].client.Router.sendPaymentV2(req)

Is it some bug of lnd 0.12.* or I do something wrong?

[Roasbeef]

Can you re-phrase your scenario?

Is it that: you can't pay 0.12 from 0.11 (using your script)? (or is it the other way around?)

[Roasbeef]

If you instead use the entire payment request (as we recommend to do so, and in your script it appears you have it available), does your scenario work as intended?

[cfromknecht]

@LNBIG-COM perhaps try setting the dest_features in the request?

Specifically with FEATURE_BIT_MPP_OPT and FEATURE_BIT_TLV_ONION_OPT (from https://github.com/lightningnetwork/lnd/blob/master/lnrpc/rpc.proto#L3266)

[Roasbeef]

If you're paying from lnd 0.11 -> 0.12, then you need to use the full payment request as 0.11 doesn't have that field (payment_addr). If you switch to using the invoice, then the same script should work for all versions of lnd released in the past year or so.

[LNBIG-COM]

@LNBIG-COM perhaps try setting the dest_features in the request?

Specifically with FEATURE_BIT_MPP_OPT and FEATURE_BIT_TLV_ONION_OPT (from https://github.com/lightningnetwork/lnd/blob/master/lnrpc/rpc.proto#L3266)

I didn't it.

I did the same as was recommended by @Roasbeef in #4900 (comment):

if you were makign payments by manually specifying the details (destination, pay hash, etc), then you should switch to either generating and paying full invoices, or specifying the new payment_addr field in the existing APIs

But now i see in the sources of LND v0.11.1-beta.rc5 and i see there the method SendPaymentV2 but in the SendPaymentRequest message I don't see payment_addr in proto file. I saw in API doc at the site and I thought that if lnd has the SendPaymentV2 that it has payment_addr. The nodejs's gRPC module doesn't check is there payment_addr or not and it doesn't throw exception.

In this case, I still don't understand even more - how can I pay invoices for lnd 0.12 from lnd 0.11 without using a full request (I want to thus control the sending process more, because I need to send the payment only through certain channels by outgoing_chan_ids).

If you instead use the entire payment request (as we recommend to do so, and in your script it appears you have it available), does your scenario work as intended?

I didn't use the entire payment request. I wanted to try your hint #3 to use payment_addr from there: #4900 (comment)

[LNBIG-COM]

If you're paying from lnd 0.11 -> 0.12, then you need to use the full payment request as 0.11 doesn't have that field (payment_addr). If you switch to using the invoice, then the same script should work for all versions of lnd released in the past year or so.

If I use a full payment request, but at the same time indicate certain channels (outgoing_chan_ids) for outgoing payment - will this be taken into account internally?

[LNBIG-COM]

Now I started using the full payment request. So far, invoices have been paid without problems. I hope there are no errors and everything works as it should. I propose to correct the documentation - indicate that the payment_addr field does not work in versions before v0.12

                let req = {
                    payment_request: res.payment_request,
                    fee_limit_sat: 0,
                    outgoing_chan_ids: [command.chanId],
                    timeout_seconds: 9,
                }