Skip to content

[bug]: CommitSig deficiency causes HTLCs insufficiently populated on node restart #9031

@dstadulis

Description

@dstadulis

Background

[incomplete background]

  1. In the scenario where one nodes hangs during of path finding,
  2. The data which lnd CommitSig handles ?results in a deficient state
  3. Which results in downstream uses of lnd (tapd in this case) where HT sigs are blank

Initial CommitSig deficiency

lnd/lnwallet/channel.go

Lines 4096 to 4108 in dcd921a

// If we signed this state, then we'll accumulate
// another update to send over.
case err == nil:
commitSig := &lnwire.CommitSig{
ChanID: lnwire.NewChanIDFromOutPoint(
lc.channelState.FundingOutpoint,
),
CommitSig: newCommit.CommitSig,
HtlcSigs: newCommit.HtlcSigs,
PartialSig: newCommit.PartialSig,
}
updates = append(updates, commitSig)

This should be set:

AuxSigBlob: commitDiff.CommitSig.ExtraData,

TODO

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions