Skip to content

bump ltc payment limit#1000

Closed
Jasonhcwong wants to merge 2 commits into
lightningnetwork:masterfrom
Jasonhcwong:bump_ltc_payment_limit
Closed

bump ltc payment limit#1000
Jasonhcwong wants to merge 2 commits into
lightningnetwork:masterfrom
Jasonhcwong:bump_ltc_payment_limit

Conversation

@Jasonhcwong
Copy link
Copy Markdown

increase litecoin payment limit to (0.04 * 60) as BTC is about 60 times more expensive than LTC
fixes #980

increase payment limit to 0.04 * 60
@meshcollider meshcollider added safety General label for issues/PRs related to the safety of using the software litecoin labels Apr 1, 2018
@Empact
Copy link
Copy Markdown
Contributor

Empact commented Apr 5, 2018

Instead of dropping the const, how about initializing in either case in Start? In any case, I doubt you'd want to drop const on those that can carry it.

@Jasonhcwong
Copy link
Copy Markdown
Author

Isn't the value of const must be known at compile time?
The limit depends on the chain(btc or ltc) which is a "deploy time" / "run-time" decision.

@cfromknecht
Copy link
Copy Markdown
Contributor

This would require modifying the spec or adding a feature bit to signal support for larger payments

@Jasonhcwong
Copy link
Copy Markdown
Author

You are right, according to Bolt #2, the payment limit should be less than 2^24 satoshi which is about 0.16777216 BTC / LTC. So the max payment limit for litecoin will be 0.16777216 LTC (about 19 USD when LTC price is 113 USD)?

…ent limit to 1 BTC.

Add config flag "largerPayment" to enable the feature.
@Jasonhcwong
Copy link
Copy Markdown
Author

@cfromknecht I just added a local feature with feature bit 7 to support larger payment up to 1 BTC/LTC. There is also a config flag "largerpayment" to enable this feature.

Copy link
Copy Markdown
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Jasonhcwong! We won't be going forward with the feature bit since we are really the only implementation that fully supports Litecoin. We'll need to bump up the channel capacity by 60x when running on the Litecoin chain.

@Jasonhcwong
Copy link
Copy Markdown
Author

@wpaulino, I think c-lightning support Litecoin too and BTCPayServer is using c-lightning as backend. Simply bump up channel capacity by 60x may break interoperability.

@Roasbeef
Copy link
Copy Markdown
Member

Roasbeef commented Jun 2, 2018

Closed as the other PR bumped up by 60x, we'll need to create a proper feature bit in the near future, but this at least lets lnd nodes use LN on Litecoin rn.

@Roasbeef Roasbeef closed this Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safety General label for issues/PRs related to the safety of using the software

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add configuration option to start lnd without the value limits

6 participants