Start deprecating noencryptwallet#1843
Merged
Roasbeef merged 9 commits intoSep 13, 2018
Merged
Conversation
cfromknecht
force-pushed
the
change-noencryptwallet
branch
from
6a6c0e2 to
fae2052
Compare
cfromknecht
force-pushed
the
change-noencryptwallet
branch
from
fae2052 to
1ea0e0a
Compare
This commit renames the confusing noencryptwallet flag to noseedbackup, since this highlights the more crucial information of the flags behavior to the user. The description has also been capitalized to urge the user think twice about what they're doing.
We will be slowly phasing this out, though abruptly discontinuing support would be a more extensive change. For now, we will ensure that this feature is not recommended to users setting up a new wallet.
cfromknecht
force-pushed
the
change-noencryptwallet
branch
from
1ea0e0a to
9851870
Compare
Roasbeef
added
documentation
Contributor
Author
|
Heads up @NicolasDorier, the |
Contributor
|
You should add a proper error message in case a user try to use |
Member
|
It'll fail to start as is.
On Sep 13, 2018 1:40 PM, "Nicolas Dorier" <notifications@github.com> wrote:
You should add a proper error message in case a user try to use
noencryptwallet because of outdated documentation.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1843 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA87LsngjEMUvzOECRUvsl4PtAMTfsvoks5uasKmgaJpZM4WaD17>
.
|
Contributor
|
@Roasbeef fails to start with something like |
|
post-merge utACK. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR begins the process of deprecating the confusing
noencryptwalletflag, which has initially designed for testing purposes. As people have started to use this flag in the wild, it cannot be fully removed in one fell swoop due to backwards-compatibility requirements, though this will start the process of deprecating its use.The primary change in this PR is to rename the flag to
noseedbackup, as this the more critical information the user should be aware of when using this setting. The help description printed presents a more alarming tone than the prior message, and includes the caveat that no seed will be provided.References to noencryptwallet have been migrated to noseedbackup in comments throughout the codebase. The section on disabling wallet encryption has also been removed from the install docs and
sample-lnd.conf. Lastly, the docker start script has been changed to pass thenoseedbackupflag instead.NOTE: Any users that are actively using
noencryptwalletwill have to switch any scripts/confs to usenoseedbackupas a result of this PR, though no further modification should be required.