lnrpc+routing: fix unmarshallRoute and simplify route structure#1888
Conversation
joostjager
force-pushed
the
routestruct
branch
from
023c7ad to
b2709a0
Compare
joostjager
force-pushed
the
routestruct
branch
2 times, most recently
from
ff2f3ba to
573d500
Compare
|
@joostjager Possible to split into smaller commits? |
|
@halseth It is a set of changes to all belong together to make the project build again. Possible the only thing that can be split off functionally is the fix to In general, if I split in multiple commits, I want to do it in such a way that the project builds in between every commit. Have them really build on top of eachother. In this case, I don't see how it is possible. Modifying the Route struct just has a big impact in many places. I could split off the test changes from the rest, but it will result in a non-building intermediate step. Do you see a good partitioning of the changes into multiple commits? |
|
Sure, if they cannot be split into individual changes without introducing compile errors, then it is fine! 👍 |
halseth
left a comment
halseth
left a comment
There was a problem hiding this comment.
More or less LGTM now, just a few small things! 😄
There was a problem hiding this comment.
nit: can be make one line now?
halseth
added
the
first pass review done
joostjager
force-pushed
the
routestruct
branch
from
573d500 to
e07d34b
Compare
|
Needs a rebase. |
joostjager
force-pushed
the
routestruct
branch
from
e07d34b to
3ddf82f
Compare
|
Rebased |
In this commit the dependency of unmarshallRoute on edge policies being available is removed. Edge policies may be unknown and reported as nil. SendToRoute does not need the policies, but it does need pubkeys of the route hops. In this commit, unmarshallRoute is modified so that it takes the pubkeys from edgeInfo instead of channelEdgePolicy. In addition to this, the route structure is simplified. No more connection to the database at that point. Fees are determined based on incoming and outgoing amounts.
joostjager
force-pushed
the
routestruct
branch
from
3ddf82f to
a779004
Compare
4 participants
In this PR the dependency of unmarshallRoute on edge policies being
available is removed. Edge policies may be unknown and reported as nil.
SendToRoute does not need the policies, but it does need pubkeys of the
route hops. In this commit, unmarshallRoute is modified so that it
takes the pubkeys from edgeInfo instead of channelEdgePolicy.
In addition to this, the route structure is simplified. No more connection
to the database at that point. Fees are determined based on incoming and
outgoing amounts.