peer: only send send enable update for disabled chans#2017
Closed
halseth wants to merge 1 commit into
Closed
Conversation
To avoid spamming on each connection.
Roasbeef
reviewed
Oct 9, 2018
|
|
||
| // To ensure we can route through this channel now that the peer | ||
| // is back online, we'll attempt to send an update to enable it. | ||
| // If the channel is already enabled in the database, we won't |
Member
There was a problem hiding this comment.
Won't this already be done by the logic further into this execution pipeline? In that it will only send out a new update if this is a shift from the state of the past 20 mins?
Contributor
Author
There was a problem hiding this comment.
True, if we have already sent a disable+enable for this channel, the re-enabling will be ignored.
That means that this will only avoid the case where we first connect to a peer after startup, and send out a channel update for all our N channels (if all our peers are online). Maybe still good for the health of the graph not to send out N new updates after each restart?
Roasbeef
added
p2p
Contributor
Author
|
Might not be needed after strict channel enabling and related PRs. Making P4 for now. |
Contributor
Author
|
Replaced by #2080 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid spamming on each connection.