lnrpc: allow invoice.macaroon to read onchain transactions#2327
Merged
wpaulino merged 1 commit intolightningnetwork:masterfrom Oct 24, 2019
Merged
Conversation
wpaulino
reviewed
Dec 17, 2018
rpcserver.go
Outdated
Contributor
There was a problem hiding this comment.
Perhaps this should be added as an additional permission? Nothing uses the address permission at the moment, but there could a RPC added in the future that does.
Contributor
|
LGTM after squashing the commits. |
Contributor
Author
|
do I have to squash or are you squashing on merge? |
ottosuess
force-pushed
the
invoice_macaroon_permissions
branch
from
e4fc96a to
c7c85ff
Compare
Contributor
Author
|
squashed 🔥 |
wpaulino
approved these changes
Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #2236
The invoice macaroon has permissions to create off-chain & on-chain requests but it can only check for off-chain payments using the
LookupInvoice,ListInvoices&SubscribeInvoicescalls.This pr enables the
SubscribeTransactionsandGetTransactionscalls for theinvoice.macaroon