netann: move NodeSigner out of main package#2416
Merged
cfromknecht merged 3 commits intoJan 10, 2019
Merged
Conversation
5 tasks
cfromknecht
added
trivial
code health
halseth
previously approved these changes
Jan 8, 2019
Contributor
There was a problem hiding this comment.
nit: ideally should be done in same commit as rename to ensure compilation is intact
Contributor
Author
There was a problem hiding this comment.
split into add, rename, remove to maintain compilation and distinct files for rebasability. Final diff should appear the same as a rename
Contributor
There was a problem hiding this comment.
Hm, this leaves the commit history a bit bloated and not as nice to read commit-by-commit, but maybe this indeed is the only way we can ensure each commit compiles 🤔
Contributor
Author
There was a problem hiding this comment.
yeah seems the only way if we want to try to keep the one commit/file :S
cfromknecht
force-pushed
the
netann-node-signer
branch
from
3f3f459 to
7987a41
Compare
halseth
approved these changes
Jan 9, 2019
wpaulino
approved these changes
Jan 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A preliminary step for #2411, this PR moves the node signer out of the main package and updates the server to use the imported object.