Skip to content

server: configurable min backoff#2417

Merged
halseth merged 2 commits into
lightningnetwork:masterfrom
cfromknecht:min-backoff
Jan 8, 2019
Merged

server: configurable min backoff#2417
halseth merged 2 commits into
lightningnetwork:masterfrom
cfromknecht:min-backoff

Conversation

@cfromknecht
Copy link
Copy Markdown
Contributor

@cfromknecht cfromknecht commented Jan 4, 2019

This PR adds a --minbackoff configuration option, which allows one to specify the minimum backoff used when reconnecting to persistent peers. The current value is hard coded at 1 second, which remains the default configuration.

This is useful in integration tests that depend on reliably disconnecting peers, and testing behaviors in the absence of a successful reconnection. We can simulate this even by now setting the min back off to a reasonably high value, such as to not interfere with the tests.

Prepration for #2411

@cfromknecht cfromknecht mentioned this pull request Jan 4, 2019
5 tasks
@cfromknecht cfromknecht added p2p Code related to the peer-to-peer behaviour server labels Jan 5, 2019
Copy link
Copy Markdown
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🗿

Copy link
Copy Markdown
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@halseth halseth merged commit 3ab0189 into lightningnetwork:master Jan 8, 2019
@cfromknecht cfromknecht deleted the min-backoff branch January 10, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2p Code related to the peer-to-peer behaviour server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants