htlcswitch+routing: handle unknown failure source#3046
Closed
joostjager wants to merge 4 commits into
Closed
Conversation
joostjager
force-pushed
the
invalid-failure-handling
branch
2 times, most recently
from
63123e6 to
d7bf53f
Compare
As a preparation for construction of forwarding errors with an unknown source, this commit updates the String() function to not generate a nil ptr error.
joostjager
force-pushed
the
invalid-failure-handling
branch
2 times, most recently
from
44606a0 to
8fa8110
Compare
joostjager
force-pushed
the
invalid-failure-handling
branch
from
8fa8110 to
cd601f6
Compare
This commit modifies the switch to properly signal the case where the error source is unknown. Previously the self node was reported as the source of the error. Handling of an unknown error source in router is modified to prune all channel edges along the route, as the cause of this error could be any node.
joostjager
force-pushed
the
invalid-failure-handling
branch
from
cd601f6 to
3820691
Compare
Contributor
Author
|
Combined with #3188 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the switch to properly signal the case where the error source is unknown. Previously the self node was reported as the source of the error.
Handling of an unknown error source in router is modified to prune all channel edges along the route, as the cause of this error could be any node.