Skip to content

lnwallet: add commitment transaction sorting with CLTV tie breaker#3142

Merged
Roasbeef merged 2 commits into
lightningnetwork:masterfrom
cfromknecht:htlc-tie-breaker
Jun 5, 2019
Merged

lnwallet: add commitment transaction sorting with CLTV tie breaker#3142
Roasbeef merged 2 commits into
lightningnetwork:masterfrom
cfromknecht:htlc-tie-breaker

Conversation

@cfromknecht
Copy link
Copy Markdown
Contributor

@cfromknecht cfromknecht commented May 30, 2019

Updates commitment transaction sorting to be consistent with lightning/bolts#491

Fixes #2234

@cfromknecht cfromknecht added this to the 0.7 milestone May 30, 2019
Comment thread lnwallet/channel.go Outdated
Copy link
Copy Markdown
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌪

Would be nice to also bring over the set of tests within txsort to test the input sort order behavior.

Copy link
Copy Markdown
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏔

@Roasbeef Roasbeef merged commit 970d760 into lightningnetwork:master Jun 5, 2019
@cfromknecht cfromknecht deleted the htlc-tie-breaker branch June 5, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid commit sig

3 participants