Skip to content

lnd: reject custom fee when force closing channel#3227

Merged
Roasbeef merged 1 commit into
lightningnetwork:masterfrom
2xic-archive:issue_3074
Jun 28, 2019
Merged

lnd: reject custom fee when force closing channel#3227
Roasbeef merged 1 commit into
lightningnetwork:masterfrom
2xic-archive:issue_3074

Conversation

@2xic
Copy link
Copy Markdown
Contributor

@2xic 2xic commented Jun 20, 2019

This fixes #3074

Copy link
Copy Markdown
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, LGTM! 🏖

@cfromknecht
Copy link
Copy Markdown
Contributor

one small thing, you'll need to run go fmt -w -s rpcserver.go, then push again

rpcserver.go:1::warning: file is not gofmted with -s (gofmt)

@2xic
Copy link
Copy Markdown
Contributor Author

2xic commented Jun 21, 2019

Fixed 👍

Copy link
Copy Markdown
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌴

@Roasbeef Roasbeef merged commit c68f747 into lightningnetwork:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent force closing channels with fee rate/conf target

4 participants