cnct: commit sweep without nursery#3644
Merged
halseth merged 8 commits intoNov 15, 2019
Merged
Conversation
joostjager
added
chain handling
commitments
Contributor
Author
|
Note to self: reporting in PendingChannels (no more nursery report) |
joostjager
force-pushed
the
commit-sweep-no-nursery
branch
from
496d99f to
a9925dc
Compare
joostjager
force-pushed
the
commit-sweep-no-nursery
branch
3 times, most recently
from
947635d to
c3b6337
Compare
joostjager
force-pushed
the
commit-sweep-no-nursery
branch
from
c3b6337 to
ff7f118
Compare
joostjager
force-pushed
the
commit-sweep-no-nursery
branch
from
ff7f118 to
840f46f
Compare
Contributor
Author
|
To do: add commit sweep resolver unit test |
joostjager
force-pushed
the
commit-sweep-no-nursery
branch
2 times, most recently
from
bed44a0 to
fad80f9
Compare
Contributor
Author
|
Unit test added, ready for review |
halseth
suggested changes
Oct 31, 2019
Contributor
halseth
left a comment
halseth
left a comment
There was a problem hiding this comment.
Awesome change, I can see this making it much simpler to add the new commitment ouputs later, and nice to have more of the sweeping being done by the sweeper 👍
joostjager
force-pushed
the
commit-sweep-no-nursery
branch
from
fad80f9 to
3a69ab2
Compare
cfromknecht
reviewed
Oct 31, 2019
joostjager
force-pushed
the
commit-sweep-no-nursery
branch
from
3a69ab2 to
af4176e
Compare
halseth
approved these changes
Nov 6, 2019
Closed
joostjager
force-pushed
the
commit-sweep-no-nursery
branch
4 times, most recently
from
01f1b14 to
5d330d6
Compare
Contributor
Author
|
Rebased on top of resolver constructors |
joostjager
removed
the
incomplete
Unify resolver specific log statements. Leaves modification of the other resolvers for a later moment when it can be combined with a real change.
This commit prepares for the commit sweep resolver to report on its state.
joostjager
force-pushed
the
commit-sweep-no-nursery
branch
from
5d330d6 to
41d84f3
Compare
cfromknecht
approved these changes
Nov 14, 2019
Contributor
cfromknecht
left a comment
cfromknecht
left a comment
There was a problem hiding this comment.
LGTM. Nice commit structure 🤘
halseth
suggested changes
Nov 14, 2019
Contributor
There was a problem hiding this comment.
check the report at various times during the test?
joostjager
force-pushed
the
commit-sweep-no-nursery
branch
from
41d84f3 to
5e7af0f
Compare
The channel arbitrator no longer passes the direct commitment output to the nursery for incubation. Instead the resolver itself will await the csv lock if any. The reason to change this now is to prevent having to deal with the (legacy) nursery code for a planned anchor outputs related change to the commit sweep resolver (also csv lock to_remote). It is no problem if there are any lingering incubating outputs at the time of upgrade. This just means that the output will be offered twice to the sweeper and this doesn't hurt.
Now that the commit sweep resolver is no longer relying on the nursery, all code associated with commit sweeping can be removed.
joostjager
force-pushed
the
commit-sweep-no-nursery
branch
from
5e7af0f to
462d86d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (finally) removes the dependency on the legacy utxo nursery from the commit sweep resolver.
The reason for doing this now, is that the new anchor output commitment format will also csv-lock the
to_remoteoutput. This requires changes and testing in this area and it seems like a good opportunity to clean up this technical debt.Subtask of #3587