flat features#3685
Merged
Merged
Conversation
cfromknecht
force-pushed
the
flat-features
branch
from
692ecf9 to
4392cc4
Compare
cfromknecht
force-pushed
the
flat-features
branch
2 times, most recently
from
aec5dae to
3e64047
Compare
cfromknecht
requested review from
Roasbeef,
halseth,
joostjager and
wpaulino
as code owners
joostjager
reviewed
Nov 8, 2019
Contributor
joostjager
left a comment
joostjager
left a comment
There was a problem hiding this comment.
First pass looking good. Main comment is about order of commits
cfromknecht
force-pushed
the
flat-features
branch
4 times, most recently
from
77cea27 to
9f80240
Compare
cfromknecht
force-pushed
the
flat-features
branch
4 times, most recently
from
b13cb6d to
79a0753
Compare
halseth
suggested changes
Nov 8, 2019
halseth
reviewed
Nov 8, 2019
This commit introduces a feature.Manager, which derives feature vectors for various contexts within the daemon. The sets can be described via a staticly compiled format, which makes any runtime adjustments to the feature sets when the manager is initialized.
cfromknecht
force-pushed
the
flat-features
branch
from
79a0753 to
5e27b50
Compare
Roasbeef
approved these changes
Nov 9, 2019
Member
Roasbeef
left a comment
Roasbeef
left a comment
There was a problem hiding this comment.
Clean set of changes! We should wait on merge until we confirm proper interop tests w/ the other main implementations, and also for the final version of the spec to be merged.
LGTM 💥
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An implementation of lightning/bolts#666