[anchors] lnrpc: add commitment_type to listchannels#4068
Conversation
halseth
changed the title
halseth
force-pushed
the
anchors-rpc-committype
branch
from
5cfd2b6 to
08d668a
Compare
There was a problem hiding this comment.
Legacy as a type isn't very scalable. Static remote key will be legacy at some point too.
There was a problem hiding this comment.
sticking with legacy 😛
There was a problem hiding this comment.
Is StaticRemoteKey also true for anchors?
There was a problem hiding this comment.
Isn't that confusing? We could also define the bool as indicating that particular format, not a format feature.
There was a problem hiding this comment.
True, it could be either or. Not sure how much it matters, as we are deprecating it.
There was a problem hiding this comment.
Indeed, it doesn't matter much. My preference would be to consider the boolean a channel type and not a channel feature, because it is simpler to explain. ListChannels only communicates channel types.
There was a problem hiding this comment.
Went with your suggestion :)
There was a problem hiding this comment.
nit: maybe (but i'm also a bit unsure) "does not change upon state changes"
There was a problem hiding this comment.
Sticking with this, as that was the original doc on static_remote_key
halseth
force-pushed
the
anchors-rpc-committype
branch
from
08d668a to
7d305fd
Compare
5 participants
Now that we have a third commitment type active (#3829), we deprecate the
static_remote_keyfield onlistchannels, and instead add anothercommitment_type.