chanbackup: add SCB support for anchor commitments#4082
Merged
Conversation
halseth
approved these changes
Mar 16, 2020
guggero
approved these changes
Mar 16, 2020
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Great that this can likely make it into 0.10.0 and we can release SAFU anchors!
LGTM 💯
In this commit, we extend the current SCB recovery tests to also cover the new anchor commitment type. We only add a single test that covers the most common case to avoid needing to tests all cases for all commitment types which is being done in a follow up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we add SCB support for anchor commitments and update the integration tests to add a single case to cover SCB file recovery for anchor commitments. We only add a single case here in order to leave the more encompassing itest overhaul for all commitment types to: #4001