lnwallet: absolute fee floor sanity check#4211
Merged
Roasbeef merged 2 commits intoApr 21, 2020
Merged
Conversation
Crypt-iQ
requested changes
Apr 21, 2020
Collaborator
Crypt-iQ
left a comment
Crypt-iQ
left a comment
There was a problem hiding this comment.
Travis failing with unable to send fee update, see below comment.
cfromknecht
force-pushed
the
absolute-fee-floor
branch
from
e8f8360 to
e4cd298
Compare
Crypt-iQ
approved these changes
Apr 21, 2020
Collaborator
Crypt-iQ
left a comment
Crypt-iQ
left a comment
There was a problem hiding this comment.
LGTM once travis green 🤙
This enforces the _actualized_ fee rate of the commitment transaction, rather than the fee floor used for estimation. The new value of 250 sat/kw corresponds to 1 sat/byte, rather than 253 which is only rounded up during estimation to account for the fact that BOLT 3 rounds down to the nearest satoshi and that the vbyte fee estimation is lossy. Previously we would incorrectly fail to sign the next commitment even though the fee was technically high enough. Restarting with this commit should solve the issue as long as the channel hasn't already gone to chain.
cfromknecht
force-pushed
the
absolute-fee-floor
branch
from
e4cd298 to
89bd587
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4208
This enforces the actualized fee rate of the commitment transaction,
rather than the fee floor used for estimation. The new value of 250
sat/kw corresponds to 1 sat/byte, rather than 253 which is only rounded
up during estimation to account for the fact that BOLT 3 rounds down to
the nearest satoshi and that the vbyte fee estimation is lossy.
This check was added as part of #3821 to catch any bugs in the new
anchor commitment format. The bug is not present in any official
release of lnd, but does affect master, 0.10.0-beta.rc1, and
0.10.0-beta.rc2.
For affected users, restarting with this commit should return the channel to
normal operation unless any pending htlcs have already timed out and
caused the channel to go to chain.