Skip to content

netann: decode features when creating chan ann from stored chan info#4342

Merged
Roasbeef merged 1 commit into
lightningnetwork:masterfrom
wpaulino:create-chan-ann-zero-features
Jun 3, 2020
Merged

netann: decode features when creating chan ann from stored chan info#4342
Roasbeef merged 1 commit into
lightningnetwork:masterfrom
wpaulino:create-chan-ann-zero-features

Conversation

@wpaulino
Copy link
Copy Markdown
Contributor

@wpaulino wpaulino commented Jun 2, 2020

This was the only field not properly set when creating a lnwire.ChannelAnnouncement from a channeldb.ChannelEdgeInfo.

Fixes #4322.

This was the only field not properly set when creating a
lnwire.ChannelAnnouncement from a channeldb.ChannelEdgeInfo.
Copy link
Copy Markdown
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

Copy link
Copy Markdown
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌊

@Roasbeef Roasbeef merged commit 09bb9db into lightningnetwork:master Jun 3, 2020
@Roasbeef Roasbeef added this to the 0.11.0 milestone Jun 3, 2020
@wpaulino wpaulino deleted the create-chan-ann-zero-features branch June 3, 2020 03:13
@cfromknecht cfromknecht modified the milestones: 0.11.0, 0.10.2 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nodes sending invalid channel announcements in gossip (sig check fails, as features field was zeroed out)

3 participants