lnwire: Support upfront shutdown script feature#449
Closed
stevenroose wants to merge 1 commit into
Closed
Conversation
stevenroose
force-pushed
the
upfront-shutdown-script
branch
from
b3c8f28 to
5bd5d11
Compare
Member
|
As is, this PR is incomplete as it doesn't actually implement the logic to use the option if supported by the other party, or ensure that both sides commit to the same delivery script. |
Contributor
Author
|
I suppose you mean s/complete/incomplete? I know, it's an lnwire update, though. It doesn't make lnd use the feature flag yet, so it just makes it understand peers using the feature flag. |
stevenroose
force-pushed
the
upfront-shutdown-script
branch
from
5bd5d11 to
30807f0
Compare
meshcollider
added
the
wire protocol
stevenroose
force-pushed
the
upfront-shutdown-script
branch
from
30807f0 to
3a68a82
Compare
Member
|
Needs a rebase! |
stevenroose
force-pushed
the
upfront-shutdown-script
branch
2 times, most recently
from
534968e to
b4ba2b1
Compare
Contributor
Author
|
I tried rebasing, but I forgot about the original logic so I can't reliably review my own work :) So I trust your reviewing judgement! |
Collaborator
|
Replaced with #3655, this commit is included in the new PR 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that this was part of the RFC, but not yet implemented here.