multi: add new config option to toggle gossip rate limiting #4810
Conversation
Roasbeef
requested review from
cfromknecht,
halseth and
wpaulino
as code owners
Roasbeef
force-pushed
the
gossip-throttle-config
branch
from
2e4ec36 to
7ab8001
Compare
cfromknecht
left a comment
cfromknecht
left a comment
There was a problem hiding this comment.
changes read well to me. main question i have is do we know exactly why the current itest's updates are being ratelimited? have we confirmed that our tests actually send keep-alive updates?
I think mainly because our "24hr clock" in the tests is "true", and just even the |
In this commit, we add a new option to toggle gossip rate limiting. This new option can be useful in contexts that require near instant propagation of gossip messages like integration tests.
Roasbeef
force-pushed
the
gossip-throttle-config
branch
from
7ab8001 to
447c9f2
Compare
halseth
left a comment
halseth
left a comment
There was a problem hiding this comment.
Changes LGTM, we should do everything in our power to make travis green again.
However, it is all red for this PR now 😬
|
Merging this. Current itest failure seems related to #4782, looking into that separately. |
3 participants
In this PR, we add a new legacy protocol config option to allow the itests to enable/disable gossip throttling for each new node (default is no throttling in the itests). We also pull in a commit meant to restore stability to the set of itests by reducing the number of parallel itests execution instances to 1 (effectively disabling the parallelization).