watchtower/wtclient: add prefix logging#4885
Merged
Merged
Conversation
guggero
approved these changes
Dec 27, 2020
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
LGTM, just one small nit.
The backup_task.go file also has a call to the package-level log variable on line #205. But that contains the anchor bool in the message itself so it's probably not worth adding a prefix logger just for that single line.
halseth
approved these changes
Jan 4, 2021
cfromknecht
force-pushed
the
wtwr-logging
branch
from
157b896 to
e0e5764
Compare
Contributor
Author
yeah this was also my thinking. that log should never execute anyway 👌 |
Collaborator
|
PR is good to go IMO. Do we want this for RC4? |
Contributor
Author
|
@guggero yes i think so, otherwise it will be difficult to debug watchtower logs in 0.12+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #4782, adds the
(legacy)or(anchor)prefix to logs output by the individual sub-clients