Address (most) golint issues#5
Conversation
* silence all golint complaints except for those caused by generated gRPC code in rpc.pb.go, as well as the OP_CHECKSEQUENCEVERIFY opcode in script_utils.go
There was a problem hiding this comment.
You mind reconciling this comment now?
It should read something like:
// Importing the bdb package in order to register the boltdb implementation of the walletdb interface.
|
Hey Paul, thanks for another PR! It's correct that all the Also, it's worth nothing that many of these lint errors exist, simply because much of the code in Could you rebase this to catch it up to the latest master? The merge may be a bit hairy as Tadge, and I have recently merged some development branches into master... |
|
@Roasbeef I mostly wanted a good excuse to take a stroll through the whole I get that the |
|
Closing this out to avoid merge headache (when I get some free time I may go through |
PaulCapestany
changed the title
Step lightningnetwork#5 in making htlcManager (aka channelLink) testable: Combine all that have been done so far and add test framework for channel links which allow unit test: * message ordering * detect redundant messages * single hop payment * multihop payment * several cancel payment scenarios
Step lightningnetwork#5 in making htlcManager (aka channelLink) testable: Combine all that have been done so far and add test framework for channel links which allow unit test: * message ordering * detect redundant messages * single hop payment * multihop payment * several cancel payment scenarios
Step lightningnetwork#5 in making htlcManager (aka channelLink) testable: Combine all that have been done so far and add test framework for channel links which allow unit test: * message ordering * detect redundant messages * single hop payment * multihop payment * several cancel payment scenarios
Step lightningnetwork#5 in making htlcManager (aka channelLink) testable: Combine all that have been done so far and add test framework for channel links which allow unit test: * message ordering * detect redundant messages * single hop payment * multihop payment * several cancel payment scenarios
Step #5 in making htlcManager (aka channelLink) testable: Combine all that have been done so far and add test framework for channel links which allow unit test: * message ordering * detect redundant messages * single hop payment * multihop payment * several cancel payment scenarios
2 participants
Silence all complaints when
golint ./...is run, except for those caused by generated gRPC code in rpc.pb.go, as well as the OP_CHECKSEQUENCEVERIFY opcode in script_utils.goFixed:
Left as-is: