lntest/itest: fix SendPaymentAMP test#5725
Merged
Merged
Conversation
|
Visit https://dashboard.github.orijtech.com?back=0&pr=5725&remote=true&repo=bottlepay%2Flnd to see benchmark details. |
joostjager
force-pushed
the
fix-amp-itest
branch
from
f5eff84 to
dfdb01e
Compare
Merged
joostjager
force-pushed
the
fix-amp-itest
branch
from
dfdb01e to
ee10178
Compare
guggero
reviewed
Sep 14, 2021
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Nice that you found the fix so quickly! One question about the timeout.
joostjager
force-pushed
the
fix-amp-itest
branch
from
ee10178 to
3827d15
Compare
bhandras
approved these changes
Sep 14, 2021
| // Subscribe to bob's invoices. Do this early in the test to make sure | ||
| // that the subscription has actually been completed when we add an | ||
| // invoice. Otherwise the notification will be missed. | ||
| req := &lnrpc.InvoiceSubscription{} |
Collaborator
There was a problem hiding this comment.
I belive we could fix this below in testSendToRouteAMP too.
Contributor
Author
There was a problem hiding this comment.
I think that one has sufficient delay because it jit-inserts the invoice when the htlc arrives. It is kind of unsatisfactory that the subscribe call doesn't give a signal when it is actually subscribed though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes timing issue that caused missed invoice notification.