Skip to content

replace all instances of 'ln' with 'lightning' in README.md#6

Closed
shea256 wants to merge 1 commit into
lightningnetwork:masterfrom
shea256:master
Closed

replace all instances of 'ln' with 'lightning' in README.md#6
shea256 wants to merge 1 commit into
lightningnetwork:masterfrom
shea256:master

Conversation

@shea256
Copy link
Copy Markdown

@shea256 shea256 commented Jan 26, 2016

No description provided.

Comment thread README.md
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this without changing the name of the repo will cause future go get ... calls to fail.

@Roasbeef
Copy link
Copy Markdown
Member

Roasbeef commented Feb 3, 2016

Hey @shea256, thanks for the PR!

Changing the name of the project isn't as simple as changing a few lines in the README. As I pointed out in the comments above, changing the instructions for go get ... will break the installation command for users. In order to change the project name, while maintaining links circulating, we'll have to create a new repo, and edit the README of this repo pointing over to the new one.

As this change may be a bit involved, I'm closing this PR for now. We'll handle the steps required to make a smooth switchover.

@Roasbeef Roasbeef closed this Feb 3, 2016
@shea256
Copy link
Copy Markdown
Author

shea256 commented Feb 4, 2016

@Roasbeef I realize that, I'm not a noob 😄

My point was to demonstrate how the language could be much better and how it would improve the branding / developer aesthetics, so I made some quick edits to the README.md file.

I figured someone on the team would have to go through and make edits to variable names and such and multiple commits would be required for the update.

Also I don't see why you'll need to create a new repo. Are you having people install directly from GitHub? I'm not quite familiar with go but surely it must have a package manager.

And sounds good RE the switchover.

@shea256
Copy link
Copy Markdown
Author

shea256 commented Feb 4, 2016

It seems you should be able to do this without creating a new repo, but I could be mistaken.

@Roasbeef
Copy link
Copy Markdown
Member

Roasbeef commented Feb 4, 2016

Yep, Go has a package manager. Go source code stored locally in a special "workspace". Within this workspace, packages are partitioned (under $GOPATH/src/) according to which version source control software each project uses. So if we change the name, then all go get ... pointers, and the folder structure locally would need to change also. Users could either re-name everything, or just nuke then start over.

A new repo would be required in order to avoid killing any active links to lnd on the net. Links to github.com/LightningNetwork/lnd would be broken since Github doesn't set up redirects if a repo name is changed.

@Roasbeef
Copy link
Copy Markdown
Member

Roasbeef commented Feb 4, 2016

Actually, I'm wrong: Github does in fact redirect old links

@shea256
Copy link
Copy Markdown
Author

shea256 commented Feb 4, 2016

Yes of course, I knew that. I rename repos all the time.

@beussdelanight beussdelanight mentioned this pull request Apr 8, 2018
@xiaofo09 xiaofo09 mentioned this pull request Apr 15, 2018
bjarnemagnussen added a commit to LN-Zap/lnd that referenced this pull request Jun 11, 2021
Add option to call AbandonChannel by validating the remote pubkey in non-development builds
bjarnemagnussen added a commit to LN-Zap/lnd that referenced this pull request Sep 13, 2021
This reverts commit 5cfa595.
lnd 0.13.1 will also allow calling `abandonchannel` in non-debug builds (see lightningnetwork#5335)
ziggie1984 referenced this pull request in ziggie1984/lnd Oct 2, 2024
accept 'signet' as LND_ENVIRONMENT variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants