contractcourt: only supplement resolvers if channel has historical state#6003
Closed
Roasbeef wants to merge 2 commits intolightningnetwork:masterfrom
Closed
contractcourt: only supplement resolvers if channel has historical state#6003Roasbeef wants to merge 2 commits intolightningnetwork:masterfrom
Roasbeef wants to merge 2 commits intolightningnetwork:masterfrom
Conversation
Collaborator
Could change commit message to say older channels don't have it |
Member
Author
|
cc @robtex |
Roasbeef
force-pushed
the
historical-resolver-state
branch
from
d84ad7f to
608e0c3
Compare
Crypt-iQ
reviewed
Nov 18, 2021
Collaborator
Crypt-iQ
left a comment
Crypt-iQ
left a comment
There was a problem hiding this comment.
think the itests are flakes
Member
Author
|
Confirmed from a user so far this resolved the issue 👍 |
In this commit, we fix a bug that would cause newly updated nodes to be unable to start up, if they have an older channel that was closed before we started to store all the historical state for each channel. The issue is that we started to write the complete state to disk, but newer channels don't have it, so when we try to supplement the resolvers, we run into this error. Ultimately, we only need this new supplemented information for script enforcement channels. Ideally we would instead check the channel type there instead, but it doesn't appear to be available in this context as is, without further changes. Fixes lightningnetwork#6001.
Roasbeef
force-pushed
the
historical-resolver-state
branch
from
608e0c3 to
2bb4668
Compare
Collaborator
|
Replaced by #6026. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we fix a bug that would cause newly updated nodes to be
unable to start up, if they have an older channel that was closed before
we started to store all the historical state for each channel.
The issue is that we started to write the complete state to disk, but
newer channels don't have it, so when we try to supplement the
resolvers, we run into this error.
Ultimately, we only need this new supplemented information for script
enforcement channels. Ideally we would instead check the channel type
there instead, but it doesn't appear to be available in this context as
is, without further changes.
Fixes #6001.