routing: remove newRoute#6920
Draft
joostjager wants to merge 3 commits intolightningnetwork:masterfrom
Draft
Conversation
joostjager
force-pushed
the
remove-newroute
branch
from
27fdb50 to
c18f8a2
Compare
joostjager
commented
Sep 15, 2022
| // Allocate a list that will contain the unified policies for this | ||
| // route. | ||
| edges := make([]*unifiedPolicy, len(hops)) | ||
| var ( |
Contributor
Author
There was a problem hiding this comment.
Instead of removing newRoute from BuildRoute, we can also skip that and re-route BuildRoute to pathfinding: #6921
This was referenced Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #6912. It removes
newRoutecompletely and forces pathfinding and route building to construct its own routes.The advantage of this more direct approach is that there is no chance that
newRouteyields a different route than what pathfinding worked with. Potential bugs are exposed and not "smoothed over" bynewRoute. Also some of the steps to get to the final route don't need to be executed twice.The change to
BuildRoutealso fixes edge cases withmin_htlcwhere a valid route wasn't expressible throughnewRoute's input parameters.