lnwire: limit channel update reader#7262
Merged
Roasbeef merged 1 commit intolightningnetwork:masterfrom Jan 5, 2023
Merged
Conversation
joostjager
force-pushed
the
fix-failure-tlv
branch
from
a4cf0fa to
718a2c5
Compare
joostjager
force-pushed
the
fix-failure-tlv
branch
from
718a2c5 to
0395fbc
Compare
Collaborator
|
@guggero: review reminder |
Fixes a bug where channel update data is read until the end of the stream rather than stopping after the specified length. This is problematic when failure message tlv data is present, because this data is interpreted as channel update tlv data.
joostjager
force-pushed
the
fix-failure-tlv
branch
from
0395fbc to
3835b90
Compare
Contributor
Author
|
Rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where channel update data is read until the end of the stream rather than stopping after the specified length. This is problematic when failure message tlv data is present, because this data is interpreted as channel update tlv data. The extra data isn't covered by the channel update signature, and the channel update is discarded.
Thanks to @t-bast for pointing this out.