docs: add notes on contents of Postgres DB as Key-Value store to Postgres.md#7442
Conversation
ellemouton
left a comment
There was a problem hiding this comment.
Thanks for the PR @84adam!
Pls see our contributor guidelines for how to structure your commit title.
So would suggest something like: docs: add <short description here>
Also please add an entry to the release notes
|
Thank you, @ellemouton. Updated. |
yyforyongyu
left a comment
There was a problem hiding this comment.
Thanks for the PR! @ellemouton 's comment is not addressed thought,
So would suggest something like: docs: add
So the git commit messages need to be updated as suggested.
bc20229 to
69ce385
Compare
|
Thanks, @yyforyongyu. I believe I have corrected this now. |
69ce385 to
21bc1a1
Compare
|
@yyforyongyu I believe the requested changes have been completed. (Squashed commits.) Please let me know if I'm missing anything else. Thanks! |
21bc1a1 to
713dece
Compare
|
Removed previous "references" and squashed commits. |
yyforyongyu
left a comment
There was a problem hiding this comment.
LGTM✅ Thanks again for the PR!
ellemouton
left a comment
There was a problem hiding this comment.
Looks good! I think it could be worth adding an entry to sqlite.md too. Or at least linking to this explanation from there?
|
Anything I'm missing for this PR? Curious if you have any idea when it might be merged? @ellemouton @yyforyongyu Thanks! |
|
@84adam added to |
Change Description
Adding notes on how Postgres DB is currently used as a Key-Value store, and which tables are included.
Addresses Issue #6619 - "Missing documentation for postgresql database structure"
Steps to Test
Key/Value pairs are not all TLV-encoded. Schema/structure is unclear (outside of K/V column names). However, some Key Names and Values are possible to decode into human-readable strings. For example: I used Python + psycopg2 + text processing to decode some of these, such as Node names (see comment on Gist): https://gist.github.com/84adam/d85f5f40e8821925585f263f68b655eb
SQL statements do not reveal any consistent encoding or structure:
This documentation update attempts to make clear that users cannot expect consistency for now in issuing SQL queries to their Postgres databases, and points out where more documentation will be required once additional schema is introduced into these tables.