add sats_per_kweight option when crafting a transaction#7443
Closed
ziggie1984 wants to merge 0 commit intolightningnetwork:masterfrom
Closed
add sats_per_kweight option when crafting a transaction#7443ziggie1984 wants to merge 0 commit intolightningnetwork:masterfrom
ziggie1984 wants to merge 0 commit intolightningnetwork:masterfrom
Conversation
c52c513 to
2cfc4ae
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the commands
SendCoins,SendMany,CloseChannel,OpenChannel,BatchOpenChanneland in the response of theEstimateFeecommand the optionsats_per_kweightis added to allow for more granular control of fees when creating transactions.In the current fee environment one cannot use decimal fee estimates for sats_per_vbyte, therefore using sats_per_kweight one will be able to use decimal sats_per_vbyte feerates indirectly without introducing floating point math.
Currently in the lnd backend the option sats_per_kweight is prioritized in case both options are present at the same time (sats_per_kweight and sats_per_vbyte). Though having both of them set is prevented on
lnclilevel. This might be open for discussion.Steps to Test
Changes where done on the rpc level and
lnclitherefore Polar was used to test all the changed commands.Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.